Skip to content

Commit

Permalink
crypto: brcm - add NULL check on of_match_device() return value
Browse files Browse the repository at this point in the history
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.

In case of NULL print error message and return -ENODEV

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Gustavo A. R. Silva authored and Herbert Xu committed Jul 18, 2017
1 parent 24086e3 commit c609048
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/crypto/bcm/cipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -4813,6 +4813,11 @@ static int spu_dt_read(struct platform_device *pdev)
int err;

match = of_match_device(of_match_ptr(bcm_spu_dt_ids), dev);
if (!match) {
dev_err(&pdev->dev, "Failed to match device\n");
return -ENODEV;
}

matched_spu_type = match->data;

if (iproc_priv.spu.num_spu > 1) {
Expand Down

0 comments on commit c609048

Please sign in to comment.