Skip to content

Commit

Permalink
drm/panel/panel-sitronix-st7701: Remove panel on DSI attach failure
Browse files Browse the repository at this point in the history
In case mipi_dsi_attach() fails, call drm_panel_remove() to
avoid memory leak.

Fixes: 849b2e3 ("drm/panel: Add Sitronix ST7701 panel driver")
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20221014231106.468063-1-marex@denx.de
  • Loading branch information
Marek Vasut authored and Linus Walleij committed Nov 1, 2022
1 parent 49ee766 commit c621021
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion drivers/gpu/drm/panel/panel-sitronix-st7701.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,15 @@ static int st7701_dsi_probe(struct mipi_dsi_device *dsi)
st7701->dsi = dsi;
st7701->desc = desc;

return mipi_dsi_attach(dsi);
ret = mipi_dsi_attach(dsi);
if (ret)
goto err_attach;

return 0;

err_attach:
drm_panel_remove(&st7701->panel);
return ret;
}

static void st7701_dsi_remove(struct mipi_dsi_device *dsi)
Expand Down

0 comments on commit c621021

Please sign in to comment.