Skip to content

Commit

Permalink
net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
Browse files Browse the repository at this point in the history
There is no need for explicit calls of devm_kfree(), as the allocated
memory will be freed during driver's detach.

The driver core clears the driver data to NULL after device_release.
Thus, it is not needed to manually clear the device driver data to NULL.

So remove the unnecessary pci_set_drvdata() and devm_kfree().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Apr 1, 2018
1 parent ef81710 commit c679f6a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev)
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);

hnae3_unregister_ae_dev(ae_dev);

devm_kfree(&pdev->dev, ae_dev);

pci_set_drvdata(pdev, NULL);
}

static struct pci_driver hns3_driver = {
Expand Down

0 comments on commit c679f6a

Please sign in to comment.