Skip to content

Commit

Permalink
modpost: merge module iterations
Browse files Browse the repository at this point in the history
Probably, this is just a matter of the order of error/warning
messages. Merge the two for-loops.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
  • Loading branch information
Masahiro Yamada committed Dec 1, 2018
1 parent d2665ca commit c6826ad
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -2496,12 +2496,6 @@ int main(int argc, char **argv)
if (files_source)
read_symbols_from_files(files_source);

for (mod = modules; mod; mod = mod->next) {
if (mod->skip)
continue;
check_exports(mod);
}

err = 0;

for (mod = modules; mod; mod = mod->next) {
Expand All @@ -2513,6 +2507,7 @@ int main(int argc, char **argv)
buf.pos = 0;

err |= check_modname_len(mod);
check_exports(mod);
add_header(&buf, mod);
add_intree_flag(&buf, !external_module);
add_retpoline(&buf);
Expand Down

0 comments on commit c6826ad

Please sign in to comment.