Skip to content

Commit

Permalink
thermal: intel: powerclamp: Remove dead code for target mwait value
Browse files Browse the repository at this point in the history
After conversion of this driver to use powercap idle_inject core, this
driver doesn't use target_mwait value. So remove dead code.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Srinivas Pandruvada authored and Rafael J. Wysocki committed Jan 22, 2024
1 parent 6613476 commit c6a783b
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions drivers/thermal/intel/intel_powerclamp.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
*/
#define DEFAULT_DURATION_JIFFIES (6)

static unsigned int target_mwait;
static struct dentry *debug_dir;
static bool poll_pkg_cstate_enable;

Expand Down Expand Up @@ -312,34 +311,6 @@ MODULE_PARM_DESC(window_size, "sliding window in number of clamping cycles\n"
"\twindow size results in slower response time but more smooth\n"
"\tclamping results. default to 2.");

static void find_target_mwait(void)
{
unsigned int eax, ebx, ecx, edx;
unsigned int highest_cstate = 0;
unsigned int highest_subcstate = 0;
int i;

if (boot_cpu_data.cpuid_level < CPUID_MWAIT_LEAF)
return;

cpuid(CPUID_MWAIT_LEAF, &eax, &ebx, &ecx, &edx);

if (!(ecx & CPUID5_ECX_EXTENSIONS_SUPPORTED) ||
!(ecx & CPUID5_ECX_INTERRUPT_BREAK))
return;

edx >>= MWAIT_SUBSTATE_SIZE;
for (i = 0; i < 7 && edx; i++, edx >>= MWAIT_SUBSTATE_SIZE) {
if (edx & MWAIT_SUBSTATE_MASK) {
highest_cstate = i;
highest_subcstate = edx & MWAIT_SUBSTATE_MASK;
}
}
target_mwait = (highest_cstate << MWAIT_SUBSTATE_SIZE) |
(highest_subcstate - 1);

}

struct pkg_cstate_info {
bool skip;
int msr_index;
Expand Down Expand Up @@ -759,9 +730,6 @@ static int __init powerclamp_probe(void)
return -ENODEV;
}

/* find the deepest mwait value */
find_target_mwait();

return 0;
}

Expand Down

0 comments on commit c6a783b

Please sign in to comment.