Skip to content

Commit

Permalink
sched: Remove SYNC_WAKEUPS feature
Browse files Browse the repository at this point in the history
Sync wakeups are critical functionality with a long history.  Remove it, we don't
need the branch or icache footprint.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1268301817.6785.47.camel@marge.simson.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Mike Galbraith authored and Ingo Molnar committed Mar 11, 2010
1 parent f2e74ee commit c6ee36c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
3 changes: 0 additions & 3 deletions kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -2369,9 +2369,6 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
unsigned long flags;
struct rq *rq;

if (!sched_feat(SYNC_WAKEUPS))
wake_flags &= ~WF_SYNC;

this_cpu = get_cpu();

smp_wmb();
Expand Down
8 changes: 0 additions & 8 deletions kernel/sched_features.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ SCHED_FEAT(WAKEUP_PREEMPT, 1)
*/
SCHED_FEAT(ASYM_GRAN, 1)

/*
* Use the SYNC wakeup hint, pipes and the likes use this to indicate
* the remote end is likely to consume the data we just wrote, and
* therefore has cache benefit from being placed on the same cpu, see
* also AFFINE_WAKEUPS.
*/
SCHED_FEAT(SYNC_WAKEUPS, 1)

/*
* Based on load and program behaviour, see if it makes sense to place
* a newly woken task on the same cpu as the task that woke it --
Expand Down

0 comments on commit c6ee36c

Please sign in to comment.