Skip to content

Commit

Permalink
net: cadence: macb: constify pci_device_id.
Browse files Browse the repository at this point in the history
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
    791	    336	      0	   1127	    467	net/ethernet/cadence/macb_pci.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
    855	    272	      0	   1127	    467	net/ethernet/cadence/macb_pci.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Arvind Yadav authored and David S. Miller committed Jul 17, 2017
1 parent 06dc75a commit c744cf5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/cadence/macb_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static void macb_remove(struct pci_dev *pdev)
clk_unregister(plat_data->hclk);
}

static struct pci_device_id dev_id_table[] = {
static const struct pci_device_id dev_id_table[] = {
{ PCI_DEVICE(CDNS_VENDOR_ID, CDNS_DEVICE_ID), },
{ 0, }
};
Expand Down

0 comments on commit c744cf5

Please sign in to comment.