Skip to content

Commit

Permalink
genirq: Fix irqfixup, irqpoll regression
Browse files Browse the repository at this point in the history
commit d05c65f ("genirq: spurious: Run only one poller at a time")
introduced a regression, leaving the boot options 'irqfixup' and
'irqpoll' non-functional. The patch placed tests in each function, to
exit if the function is already running. The test in 'misrouted_irq'
exited when it should have proceeded, effectively disabling
'misrouted_irq' and 'poll_spurious_irqs'.

The check for an already running poller needs to be "!= 1" not "== 1"
as "1" is the value when the first poller starts running.

Signed-off-by: Edward Donovan <edward.donovan@numble.net>
Cc: maciej.rutecki@gmail.com
Link: http://lkml.kernel.org/r/1320175784-6745-1-git-send-email-edward.donovan@numble.net
Cc: stable@vger.kernel.org # >= 2.6.39
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Edward Donovan authored and Thomas Gleixner committed Nov 3, 2011
1 parent c3b92c8 commit c75d720
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/irq/spurious.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ static int misrouted_irq(int irq)
struct irq_desc *desc;
int i, ok = 0;

if (atomic_inc_return(&irq_poll_active) == 1)
if (atomic_inc_return(&irq_poll_active) != 1)
goto out;

irq_poll_cpu = smp_processor_id();
Expand Down

0 comments on commit c75d720

Please sign in to comment.