Skip to content

Commit

Permalink
r8152: remove a netif_carrier_off in rtl8152_open function
Browse files Browse the repository at this point in the history
After commit 90186af ("r8152: fix lockup when runtime PM is enabled"),
the autoresume wouldn't start the device before rtl8152_open() is finished.
Therefore, we don't have to reset the linking status before and after
autoresume. That is, one of netif_carrier_off() in rtl8152_open() could be
removed.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
hayeswang authored and David S. Miller committed Jul 9, 2016
1 parent b164806 commit c79262f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/usb/r8152.c
Original file line number Diff line number Diff line change
Expand Up @@ -3111,8 +3111,6 @@ static int rtl8152_open(struct net_device *netdev)
if (res)
goto out;

netif_carrier_off(netdev);

res = usb_autopm_get_interface(tp->intf);
if (res < 0) {
free_all_mem(tp);
Expand Down

0 comments on commit c79262f

Please sign in to comment.