Skip to content

Commit

Permalink
fat: use __getname()
Browse files Browse the repository at this point in the history
__getname() is faster than __get_free_page(). Use it.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
OGAWA Hirofumi authored and Linus Torvalds committed Apr 28, 2008
1 parent f22032b commit c7a6c4e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 16 deletions.
20 changes: 10 additions & 10 deletions fs/fat/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ static int fat_parse_long(struct inode *dir, loff_t *pos,
unsigned char id, slot, slots, alias_checksum;

if (!*unicode) {
*unicode = (wchar_t *)__get_free_page(GFP_KERNEL);
*unicode = __getname();
if (!*unicode) {
brelse(*bh);
return -ENOMEM;
Expand Down Expand Up @@ -327,7 +327,7 @@ int fat_search_long(struct inode *inode, const unsigned char *name,
loff_t cpos = 0;
int chl, i, j, last_u, err;

bufname = (unsigned char*)__get_free_page(GFP_KERNEL);
bufname = __getname();
if (!bufname)
return -ENOMEM;

Expand Down Expand Up @@ -396,8 +396,8 @@ int fat_search_long(struct inode *inode, const unsigned char *name,

bufuname[last_u] = 0x0000;
xlate_len = utf8
?utf8_wcstombs(bufname, bufuname, PAGE_SIZE)
:uni16_to_x8(bufname, bufuname, PAGE_SIZE, uni_xlate, nls_io);
?utf8_wcstombs(bufname, bufuname, PATH_MAX)
:uni16_to_x8(bufname, bufuname, PATH_MAX, uni_xlate, nls_io);
if (xlate_len == name_len)
if ((!anycase && !memcmp(name, bufname, xlate_len)) ||
(anycase && !nls_strnicmp(nls_io, name, bufname,
Expand All @@ -406,8 +406,8 @@ int fat_search_long(struct inode *inode, const unsigned char *name,

if (nr_slots) {
xlate_len = utf8
?utf8_wcstombs(bufname, unicode, PAGE_SIZE)
:uni16_to_x8(bufname, unicode, PAGE_SIZE, uni_xlate, nls_io);
?utf8_wcstombs(bufname, unicode, PATH_MAX)
:uni16_to_x8(bufname, unicode, PATH_MAX, uni_xlate, nls_io);
if (xlate_len != name_len)
continue;
if ((!anycase && !memcmp(name, bufname, xlate_len)) ||
Expand All @@ -427,9 +427,9 @@ int fat_search_long(struct inode *inode, const unsigned char *name,
err = 0;
EODir:
if (bufname)
free_page((unsigned long)bufname);
__putname(bufname);
if (unicode)
free_page((unsigned long)unicode);
__putname(unicode);

return err;
}
Expand Down Expand Up @@ -619,7 +619,7 @@ static int __fat_readdir(struct inode *inode, struct file *filp, void *dirent,
/* convert the unicode long name. 261 is maximum size
* of unicode buffer. (13 * slots + nul) */
void *longname = unicode + 261;
int buf_size = PAGE_SIZE - (261 * sizeof(unicode[0]));
int buf_size = PATH_MAX - (261 * sizeof(unicode[0]));
int long_len = utf8
? utf8_wcstombs(longname, unicode, buf_size)
: uni16_to_x8(longname, unicode, buf_size, uni_xlate, nls_io);
Expand Down Expand Up @@ -652,7 +652,7 @@ static int __fat_readdir(struct inode *inode, struct file *filp, void *dirent,
FillFailed:
brelse(bh);
if (unicode)
free_page((unsigned long)unicode);
__putname(unicode);
out:
unlock_kernel();
return ret;
Expand Down
10 changes: 4 additions & 6 deletions fs/vfat/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
if (utf8) {
int name_len = strlen(name);

*outlen = utf8_mbstowcs((wchar_t *)outname, name, PAGE_SIZE);
*outlen = utf8_mbstowcs((wchar_t *)outname, name, PATH_MAX);

/*
* We stripped '.'s before and set len appropriately,
Expand Down Expand Up @@ -565,7 +565,6 @@ static int vfat_build_slots(struct inode *dir, const unsigned char *name,
struct fat_mount_options *opts = &sbi->options;
struct msdos_dir_slot *ps;
struct msdos_dir_entry *de;
unsigned long page;
unsigned char cksum, lcase;
unsigned char msdos_name[MSDOS_NAME];
wchar_t *uname;
Expand All @@ -575,11 +574,10 @@ static int vfat_build_slots(struct inode *dir, const unsigned char *name,

*nr_slots = 0;

page = __get_free_page(GFP_KERNEL);
if (!page)
uname = __getname();
if (!uname)
return -ENOMEM;

uname = (wchar_t *)page;
err = xlate_to_uni(name, len, (unsigned char *)uname, &ulen, &usize,
opts->unicode_xlate, opts->utf8, sbi->nls_io);
if (err)
Expand Down Expand Up @@ -631,7 +629,7 @@ static int vfat_build_slots(struct inode *dir, const unsigned char *name,
de->starthi = cpu_to_le16(cluster >> 16);
de->size = 0;
out_free:
free_page(page);
__putname(uname);
return err;
}

Expand Down

0 comments on commit c7a6c4e

Please sign in to comment.