Skip to content

Commit

Permalink
HID: check empty report_list in bigben_probe()
Browse files Browse the repository at this point in the history
Add a check for empty report_list in bigben_probe().
The missing check causes a type confusion when issuing a list_entry()
on an empty report_list.
The problem is caused by the assumption that the device must
have valid report_list. While this will be true for all normal HID
devices, a suitably malicious device can violate the assumption.

Fixes: 256a90e ("HID: hid-bigbenff: driver for BigBen Interactive PS3OFMINIPAD gamepad")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Pietro Borrello authored and Jiri Kosina committed Jan 17, 2023
1 parent b12fece commit c7bf714
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/hid/hid-bigbenff.c
Original file line number Diff line number Diff line change
@@ -344,6 +344,11 @@ static int bigben_probe(struct hid_device *hid,
}

report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list;
if (list_empty(report_list)) {
hid_err(hid, "no output report found\n");
error = -ENODEV;
goto error_hw_stop;
}
bigben->report = list_entry(report_list->next,
struct hid_report, list);

0 comments on commit c7bf714

Please sign in to comment.