Skip to content

Commit

Permalink
EDAC, sb_edac: Remove NULL pointer check on array pci_tad
Browse files Browse the repository at this point in the history
pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and
hence cannot be NULL, so the NULL pointer check on pci_tad is redundant.
Remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20160908083801.14766-1-colin.king@canonical.com
Signed-off-by: Borislav Petkov <bp@suse.de>
  • Loading branch information
Colin Ian King authored and Borislav Petkov committed Sep 12, 2016
1 parent 3720957 commit c7c3540
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/edac/sb_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci,

/* Check if everything were registered */
if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 ||
!pvt-> pci_tad || !pvt->pci_ras || !pvt->pci_ta)
!pvt->pci_ras || !pvt->pci_ta)
goto enodev;

if (saw_chan_mask != 0x0f)
Expand Down Expand Up @@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci,

/* Check if everything were registered */
if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 ||
!pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras ||
!pvt->pci_ta)
!pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta)
goto enodev;

if (saw_chan_mask != 0x0f && /* -EN */
Expand Down

0 comments on commit c7c3540

Please sign in to comment.