Skip to content

Commit

Permalink
serial: add PORT_GENERIC definition
Browse files Browse the repository at this point in the history
Current pattern in the linux kernel is that every new serial driver adds
one or more new PORT_ definitions because uart_ops::config_port()
callback documentation prescribes setting port->type according to the
type of port found, or to PORT_UNKNOWN if no port was detected.

When the specific type of the port is not important to the userspace
there's no need for a unique PORT_ value, but so far there's no suitable
identifier for that case.

Provide generic port type identifier other than PORT_UNKNOWN for ports
which type is not important to userspace.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Suggested-by: Jiri Slaby <jirislaby@kernel.org>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20231008001804.889727-1-jcmvbkbc@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Max Filippov authored and Greg Kroah-Hartman committed Oct 10, 2023
1 parent 3047b5b commit c7c5be5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions include/uapi/linux/serial_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -231,4 +231,7 @@
/* Sunplus UART */
#define PORT_SUNPLUS 123

/* Generic type identifier for ports which type is not important to userspace. */
#define PORT_GENERIC (-1)

#endif /* _UAPILINUX_SERIAL_CORE_H */

0 comments on commit c7c5be5

Please sign in to comment.