Skip to content

Commit

Permalink
net/dec: Make __de_get_link_ksettings return void
Browse files Browse the repository at this point in the history
Make return value void since function never return meaningfull value

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
yuval.shaia@oracle.com authored and David S. Miller committed Jun 5, 2017
1 parent 8ec1507 commit c7c6b87
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/net/ethernet/dec/tulip/de2104x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1483,8 +1483,8 @@ static void __de_get_regs(struct de_private *de, u8 *buf)
de_rx_missed(de, rbuf[8]);
}

static int __de_get_link_ksettings(struct de_private *de,
struct ethtool_link_ksettings *cmd)
static void __de_get_link_ksettings(struct de_private *de,
struct ethtool_link_ksettings *cmd)
{
ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
de->media_supported);
Expand Down Expand Up @@ -1517,8 +1517,6 @@ static int __de_get_link_ksettings(struct de_private *de,
cmd->base.autoneg = AUTONEG_ENABLE;

/* ignore maxtxpkt, maxrxpkt for now */

return 0;
}

static int __de_set_link_ksettings(struct de_private *de,
Expand Down Expand Up @@ -1615,13 +1613,12 @@ static int de_get_link_ksettings(struct net_device *dev,
struct ethtool_link_ksettings *cmd)
{
struct de_private *de = netdev_priv(dev);
int rc;

spin_lock_irq(&de->lock);
rc = __de_get_link_ksettings(de, cmd);
__de_get_link_ksettings(de, cmd);
spin_unlock_irq(&de->lock);

return rc;
return 0;
}

static int de_set_link_ksettings(struct net_device *dev,
Expand Down

0 comments on commit c7c6b87

Please sign in to comment.