Skip to content

Commit

Permalink
vxlan: support for nexthop notifiers
Browse files Browse the repository at this point in the history
vxlan driver registers for nexthop add/del notifiers to
cleanup fdb entries pointing to such nexthops.

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Roopa Prabhu authored and David S. Miller committed May 22, 2020
1 parent 8590cee commit c7cdbe2
Showing 1 changed file with 29 additions and 4 deletions.
33 changes: 29 additions & 4 deletions drivers/net/vxlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ struct vxlan_fdb {
u16 flags; /* see ndm_flags and below */
struct list_head nh_list;
struct nexthop __rcu *nh;
struct vxlan_dev *vdev;
};

#define NTF_VXLAN_ADDED_BY_USER 0x100
Expand Down Expand Up @@ -813,8 +814,9 @@ static int vxlan_gro_complete(struct sock *sk, struct sk_buff *skb, int nhoff)
return eth_gro_complete(skb, nhoff + sizeof(struct vxlanhdr));
}

static struct vxlan_fdb *vxlan_fdb_alloc(const u8 *mac, __u16 state,
__be32 src_vni, __u16 ndm_flags)
static struct vxlan_fdb *vxlan_fdb_alloc(struct vxlan_dev *vxlan, const u8 *mac,
__u16 state, __be32 src_vni,
__u16 ndm_flags)
{
struct vxlan_fdb *f;

Expand All @@ -826,6 +828,7 @@ static struct vxlan_fdb *vxlan_fdb_alloc(const u8 *mac, __u16 state,
f->updated = f->used = jiffies;
f->vni = src_vni;
f->nh = NULL;
f->vdev = vxlan;
INIT_LIST_HEAD(&f->nh_list);
INIT_LIST_HEAD(&f->remotes);
memcpy(f->eth_addr, mac, ETH_ALEN);
Expand Down Expand Up @@ -923,7 +926,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
return -ENOSPC;

netdev_dbg(vxlan->dev, "add %pM -> %pIS\n", mac, ip);
f = vxlan_fdb_alloc(mac, state, src_vni, ndm_flags);
f = vxlan_fdb_alloc(vxlan, mac, state, src_vni, ndm_flags);
if (!f)
return -ENOMEM;

Expand Down Expand Up @@ -988,6 +991,7 @@ static void vxlan_fdb_destroy(struct vxlan_dev *vxlan, struct vxlan_fdb *f,
}

hlist_del_rcu(&f->hlist);
f->vdev = NULL;
call_rcu(&f->rcu, vxlan_fdb_free);
}

Expand Down Expand Up @@ -4598,6 +4602,25 @@ static struct notifier_block vxlan_switchdev_notifier_block __read_mostly = {
.notifier_call = vxlan_switchdev_event,
};

static int vxlan_nexthop_event(struct notifier_block *nb,
unsigned long event, void *ptr)
{
struct nexthop *nh = ptr;
struct vxlan_fdb *fdb, *tmp;

if (!nh || event != NEXTHOP_EVENT_DEL)
return NOTIFY_DONE;

list_for_each_entry_safe(fdb, tmp, &nh->fdb_list, nh_list)
vxlan_fdb_destroy(fdb->vdev, fdb, false, false);

return NOTIFY_DONE;
}

static struct notifier_block vxlan_nexthop_notifier_block __read_mostly = {
.notifier_call = vxlan_nexthop_event,
};

static __net_init int vxlan_init_net(struct net *net)
{
struct vxlan_net *vn = net_generic(net, vxlan_net_id);
Expand All @@ -4609,7 +4632,7 @@ static __net_init int vxlan_init_net(struct net *net)
for (h = 0; h < PORT_HASH_SIZE; ++h)
INIT_HLIST_HEAD(&vn->sock_list[h]);

return 0;
return register_nexthop_notifier(net, &vxlan_nexthop_notifier_block);
}

static void vxlan_destroy_tunnels(struct net *net, struct list_head *head)
Expand Down Expand Up @@ -4641,6 +4664,8 @@ static void __net_exit vxlan_exit_batch_net(struct list_head *net_list)
LIST_HEAD(list);

rtnl_lock();
list_for_each_entry(net, net_list, exit_list)
unregister_nexthop_notifier(net, &vxlan_nexthop_notifier_block);
list_for_each_entry(net, net_list, exit_list)
vxlan_destroy_tunnels(net, &list);

Expand Down

0 comments on commit c7cdbe2

Please sign in to comment.