Skip to content

Commit

Permalink
mac80211: fix start_seq_num in Rx reorder offload
Browse files Browse the repository at this point in the history
sta->last_seq_ctrl is the seq_ctrl field from the last header
seen, need to shift it 4 bits to extract the sequence number.
Otherwise the ieee80211_sn_less() check at the top of
ieee80211_sta_manage_reorder_buf drops frames until the sequence
number catches up.

Cc: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Denton Gentry <denton.gentry@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Denton Gentry authored and Johannes Berg committed Aug 26, 2014
1 parent 6c6fa49 commit c7dcb45
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/mac80211/iface.c
Original file line number Diff line number Diff line change
@@ -1175,8 +1175,8 @@ static void ieee80211_iface_work(struct work_struct *work)
if (sta) {
u16 last_seq;

last_seq = le16_to_cpu(
sta->last_seq_ctrl[rx_agg->tid]);
last_seq = IEEE80211_SEQ_TO_SN(le16_to_cpu(
sta->last_seq_ctrl[rx_agg->tid]));

__ieee80211_start_rx_ba_session(sta,
0, 0,

0 comments on commit c7dcb45

Please sign in to comment.