Skip to content

Commit

Permalink
spi: sun4i: disable clocks in the remove function
Browse files Browse the repository at this point in the history
mclk and hclk need to be disabled. Since pm_runtime_disable does
not disable the clocks, use pm_runtime_force_suspend instead.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Takuo Koguchi authored and Mark Brown committed Dec 7, 2017
1 parent 4fbd8d1 commit c810dab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-sun4i.c
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ static int sun4i_spi_probe(struct platform_device *pdev)

static int sun4i_spi_remove(struct platform_device *pdev)
{
pm_runtime_disable(&pdev->dev);
pm_runtime_force_suspend(&pdev->dev);

return 0;
}
Expand Down

0 comments on commit c810dab

Please sign in to comment.