Skip to content

Commit

Permalink
can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration
Browse files Browse the repository at this point in the history
Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.

Fixes: 5443c22 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy <dmurphy@ti.com>
Link: http://lore.kernel.org/r/20201019154233.1262589-10-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Nov 15, 2020
1 parent 1ff203b commit c81d0b6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/can/m_can/tcan4x5x.c
Original file line number Diff line number Diff line change
Expand Up @@ -527,10 +527,10 @@ static int tcan4x5x_can_remove(struct spi_device *spi)
{
struct tcan4x5x_priv *priv = spi_get_drvdata(spi);

tcan4x5x_power_enable(priv->power, 0);

m_can_class_unregister(priv->mcan_dev);

tcan4x5x_power_enable(priv->power, 0);

return 0;
}

Expand Down

0 comments on commit c81d0b6

Please sign in to comment.