Skip to content

Commit

Permalink
skd: Remove superfluous initializations from skd_isr_completion_posted()
Browse files Browse the repository at this point in the history
The value of skcmp, cmp_cntxt etc. is overwritten during every
loop iteration and is not used after the loop has finished. Hence
initializing these variables outside the loop is not necessary.
This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Bart Van Assche authored and Jens Axboe committed Aug 18, 2017
1 parent b1824ee commit c830da8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/block/skd_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2509,16 +2509,16 @@ static void skd_process_scsi_inq(struct skd_device *skdev,
static int skd_isr_completion_posted(struct skd_device *skdev,
int limit, int *enqueued)
{
volatile struct fit_completion_entry_v1 *skcmp = NULL;
volatile struct fit_completion_entry_v1 *skcmp;
volatile struct fit_comp_error_info *skerr;
u16 req_id;
u32 req_slot;
struct skd_request_context *skreq;
u16 cmp_cntxt = 0;
u8 cmp_status = 0;
u8 cmp_cycle = 0;
u32 cmp_bytes = 0;
int rc = 0;
u16 cmp_cntxt;
u8 cmp_status;
u8 cmp_cycle;
u32 cmp_bytes;
int rc;
int processed = 0;

lockdep_assert_held(&skdev->lock);
Expand Down

0 comments on commit c830da8

Please sign in to comment.