Skip to content

Commit

Permalink
ASoC: sirf-audio-codec: Fix return value check in sirf_audio_codec_dr…
Browse files Browse the repository at this point in the history
…iver_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Wei Yongjun authored and Mark Brown committed Jul 31, 2014
1 parent 9779caf commit c844805
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/soc/codecs/sirf-audio-codec.c
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,8 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)

mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
base = devm_ioremap_resource(&pdev->dev, mem_res);
if (base == NULL)
return -ENOMEM;
if (IS_ERR(base))
return PTR_ERR(base);

sirf_audio_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base,
&sirf_audio_codec_regmap_config);
Expand Down

0 comments on commit c844805

Please sign in to comment.