Skip to content

Commit

Permalink
mlx5: Remove call to ida_pre_get
Browse files Browse the repository at this point in the history
The mlx5 driver calls ida_pre_get() in a loop for no readily apparent
reason.  The driver uses ida_simple_get() which will call ida_pre_get()
by itself and there's no need to use ida_pre_get() unless using
ida_get_new().

Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Matthew Wilcox authored and David S. Miller committed Mar 20, 2018
1 parent c314c7b commit c846d8d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1647,7 +1647,6 @@ try_add_to_existing_fg(struct mlx5_flow_table *ft,

list_for_each_entry(iter, match_head, list) {
nested_down_read_ref_node(&iter->g->node, FS_LOCK_PARENT);
ida_pre_get(&iter->g->fte_allocator, GFP_KERNEL);
}

search_again_locked:
Expand Down

0 comments on commit c846d8d

Please sign in to comment.