Skip to content

Commit

Permalink
remoteproc: add helper function to check carveout device address
Browse files Browse the repository at this point in the history
This patch introduces a function to verify that a specified carveout
is fitting request device address and associated length

Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Loic Pallardy authored and Bjorn Andersson committed Oct 10, 2018
1 parent 1429cca commit c874bf5
Showing 1 changed file with 47 additions and 0 deletions.
47 changes: 47 additions & 0 deletions drivers/remoteproc/remoteproc_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,53 @@ rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...)
return mem;
}

/**
* rproc_check_carveout_da() - Check specified carveout da configuration
* @rproc: handle of a remote processor
* @mem: pointer on carveout to check
* @da: area device address
* @len: associated area size
*
* This function is a helper function to verify requested device area (couple
* da, len) is part of specified carevout.
*
* Return: 0 if carveout match request else -ENOMEM
*/
int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry *mem,
u32 da, u32 len)
{
struct device *dev = &rproc->dev;
int delta = 0;

/* Check requested resource length */
if (len > mem->len) {
dev_err(dev, "Registered carveout doesn't fit len request\n");
return -ENOMEM;
}

if (da != FW_RSC_ADDR_ANY && mem->da == FW_RSC_ADDR_ANY) {
/* Update existing carveout da */
mem->da = da;
} else if (da != FW_RSC_ADDR_ANY && mem->da != FW_RSC_ADDR_ANY) {
delta = da - mem->da;

/* Check requested resource belongs to registered carveout */
if (delta < 0) {
dev_err(dev,
"Registered carveout doesn't fit da request\n");
return -ENOMEM;
}

if (delta + len > mem->len) {
dev_err(dev,
"Registered carveout doesn't fit len request\n");
return -ENOMEM;
}
}

return 0;
}

int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
{
struct rproc *rproc = rvdev->rproc;
Expand Down

0 comments on commit c874bf5

Please sign in to comment.