Skip to content

Commit

Permalink
clk: ti: Convert to platform remove callback returning void
Browse files Browse the repository at this point in the history
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-28-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Uwe Kleine-König authored and Stephen Boyd committed Mar 29, 2023
1 parent 3fd43a2 commit c8bb21b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/clk/ti/adpll.c
Original file line number Diff line number Diff line change
Expand Up @@ -931,13 +931,11 @@ static int ti_adpll_probe(struct platform_device *pdev)
return err;
}

static int ti_adpll_remove(struct platform_device *pdev)
static void ti_adpll_remove(struct platform_device *pdev)
{
struct ti_adpll_data *d = dev_get_drvdata(&pdev->dev);

ti_adpll_free_resources(d);

return 0;
}

static struct platform_driver ti_adpll_driver = {
Expand All @@ -946,7 +944,7 @@ static struct platform_driver ti_adpll_driver = {
.of_match_table = ti_adpll_match,
},
.probe = ti_adpll_probe,
.remove = ti_adpll_remove,
.remove_new = ti_adpll_remove,
};

static int __init ti_adpll_init(void)
Expand Down

0 comments on commit c8bb21b

Please sign in to comment.