Skip to content

Commit

Permalink
arm64: dts: rockchip: Use "regulator-fixed" for btreg on px30-engicam…
Browse files Browse the repository at this point in the history
… for vcc3v3-btreg

The vcc3v3-btreg regulator only has 1 state and no state gpios defined,
so "regulator-gpio" is not the correct binding to use. "regulator-fixed"
is the correct binding to use. It supports an enable GPIO which is
needed in this case.

Signed-off-by: "Rob Herring (Arm)" <robh@kernel.org>
Link: https://lore.kernel.org/r/20250409205047.1522943-1-robh@kernel.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
  • Loading branch information
Rob Herring (Arm) authored and Heiko Stuebner committed Apr 10, 2025
1 parent 7fc027e commit c8c59bc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions arch/arm64/boot/dts/rockchip/px30-engicam-common.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,14 @@
};

vcc3v3_btreg: vcc3v3-btreg {
compatible = "regulator-gpio";
compatible = "regulator-fixed";
enable-active-high;
pinctrl-names = "default";
pinctrl-0 = <&bt_enable_h>;
regulator-name = "btreg-gpio-supply";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-always-on;
states = <3300000 0x0>;
};

vcc3v3_rf_aux_mod: regulator-vcc3v3-rf-aux-mod {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@
};

&vcc3v3_btreg {
enable-gpios = <&gpio1 RK_PC3 GPIO_ACTIVE_HIGH>;
gpios = <&gpio1 RK_PC3 GPIO_ACTIVE_HIGH>;
};
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@
};

&vcc3v3_btreg {
enable-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
};

0 comments on commit c8c59bc

Please sign in to comment.