Skip to content

Commit

Permalink
ALSA: hda: hdmi - remove redundant code comments
Browse files Browse the repository at this point in the history
Remove unnecessary comments related to pin mapping on
Intel platforms.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20191115124449.20512-3-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Kai Vehmanen authored and Takashi Iwai committed Nov 15, 2019
1 parent d577cf7 commit c8e3eb9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions sound/pci/hda/patch_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -2655,7 +2655,7 @@ static int intel_pin2port(void *audio_ptr, int pin_nid)
base_nid = intel_base_nid(codec);
if (WARN_ON(pin_nid < base_nid || pin_nid >= base_nid + 3))
return -1;
return pin_nid - base_nid + 1; /* intel port is 1-based */
return pin_nid - base_nid + 1;
}

/*
Expand All @@ -2667,7 +2667,6 @@ static int intel_pin2port(void *audio_ptr, int pin_nid)
return i;
}

/* return -1 if pin number exceeds our expectation */
codec_info(codec, "Can't find the HDMI/DP port for pin %d\n", pin_nid);
return -1;
}
Expand All @@ -2680,7 +2679,6 @@ static int intel_port2pin(struct hda_codec *codec, int port)
/* we assume only from port-B to port-D */
if (port < 1 || port > 3)
return 0;
/* intel port is 1-based */
return port + intel_base_nid(codec) - 1;
}

Expand Down Expand Up @@ -2856,7 +2854,6 @@ static int patch_i915_tgl_hdmi(struct hda_codec *codec)
return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map));
}


/* Intel Baytrail and Braswell; with eld notifier */
static int patch_i915_byt_hdmi(struct hda_codec *codec)
{
Expand Down

0 comments on commit c8e3eb9

Please sign in to comment.