Skip to content

Commit

Permalink
net: lantiq_etop: Fix return type for implementation of ndo_start_xmit
Browse files Browse the repository at this point in the history
Since Linux now supports CFI, it will be a good idea to fix mismatched
return type for implementation of hooks. Otherwise this might get
cought out by CFI and cause a panic.

ltq_etop_tx() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so
change the return type to netdev_tx_t directly.

Signed-off-by: GUO Zihua <guozihua@huawei.com>
Link: https://lore.kernel.org/r/20220902081521.59867-1-guozihua@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
GUO Zihua authored and Jakub Kicinski committed Sep 3, 2022
1 parent 7b620e1 commit c8ef3c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/lantiq_etop.c
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ ltq_etop_stop(struct net_device *dev)
return 0;
}

static int
static netdev_tx_t
ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
{
int queue = skb_get_queue_mapping(skb);
Expand Down

0 comments on commit c8ef3c9

Please sign in to comment.