Skip to content

Commit

Permalink
of: return NUMA_NO_NODE from fallback of_node_to_nid()
Browse files Browse the repository at this point in the history
Node 0 might be offline as well as any other numa node,
in this case kernel cannot handle memory allocation and crashes.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: 0c3f061 ("of: implement of_node_to_nid as a weak function")
Signed-off-by: Grant Likely <grant.likely@linaro.org>
  • Loading branch information
Konstantin Khlebnikov authored and Grant Likely committed Jun 4, 2015
1 parent ba155e2 commit c8fff7b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/of/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ EXPORT_SYMBOL(of_n_size_cells);
#ifdef CONFIG_NUMA
int __weak of_node_to_nid(struct device_node *np)
{
return numa_node_id();
return NUMA_NO_NODE;
}
#endif

Expand Down
5 changes: 4 additions & 1 deletion include/linux/of.h
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,10 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag
#if defined(CONFIG_OF) && defined(CONFIG_NUMA)
extern int of_node_to_nid(struct device_node *np);
#else
static inline int of_node_to_nid(struct device_node *device) { return 0; }
static inline int of_node_to_nid(struct device_node *device)
{
return NUMA_NO_NODE;
}
#endif

static inline struct device_node *of_find_matching_node(
Expand Down

0 comments on commit c8fff7b

Please sign in to comment.