Skip to content

Commit

Permalink
i915: when kgdb is active display compression should be off
Browse files Browse the repository at this point in the history
If the HW compression is left on, the call backs from the HW will
crash the kernel.  The only time this code is called is when kernel
mode setting is in use with kgdb and the kdb shell.

The atomic display pipe handler callback will reset everything when
kgdb restores kernel to the run state.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
CC: David Airlie <airlied@linux.ie>
  • Loading branch information
Jason Wessel committed Aug 5, 2010
1 parent 8125556 commit c924b93
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,10 @@ static void intel_update_fbc(struct drm_crtc *crtc,
goto out_disable;
}

/* If the kernel debugger is active, always disable compression */
if (in_dbg_master())
goto out_disable;

if (intel_fbc_enabled(dev)) {
/* We can re-enable it in this case, but need to update pitch */
if ((fb->pitch > dev_priv->cfb_pitch) ||
Expand Down

0 comments on commit c924b93

Please sign in to comment.