Skip to content

Commit

Permalink
[PATCH] PNP: adjust pnp_register_card_driver() signature: wavefront
Browse files Browse the repository at this point in the history
Remove the assumption that pnp_register_card_driver() returns the
number of devices claimed.  And fix some __init/__devinit issues.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Jaroslav Kysela <perex@suse.cz>
Acked-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Bjorn Helgaas authored and Linus Torvalds committed Mar 27, 2006
1 parent 3812595 commit c94ded6
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions sound/isa/wavefront/wavefront.c
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ snd_wavefront_probe (struct snd_card *card, int dev)
return snd_card_register(card);
}

static int __init snd_wavefront_nonpnp_probe(struct platform_device *pdev)
static int __devinit snd_wavefront_nonpnp_probe(struct platform_device *pdev)
{
int dev = pdev->id;
struct snd_card *card;
Expand Down Expand Up @@ -637,6 +637,7 @@ static struct platform_driver snd_wavefront_driver = {


#ifdef CONFIG_PNP
static unsigned int __devinitdata wavefront_pnp_devices;

static int __devinit snd_wavefront_pnp_detect(struct pnp_card_link *pcard,
const struct pnp_card_device_id *pid)
Expand Down Expand Up @@ -670,6 +671,7 @@ static int __devinit snd_wavefront_pnp_detect(struct pnp_card_link *pcard,

pnp_set_card_drvdata(pcard, card);
dev++;
wavefront_pnp_devices++;
return 0;
}

Expand Down Expand Up @@ -729,10 +731,10 @@ static int __init alsa_card_wavefront_init(void)
}

#ifdef CONFIG_PNP
i = pnp_register_card_driver(&wavefront_pnpc_driver);
if (i >= 0) {
err = pnp_register_card_driver(&wavefront_pnpc_driver);
if (!err) {
pnp_registered = 1;
cards += i;
cards += wavefront_pnp_devices;
}
#endif

Expand Down

0 comments on commit c94ded6

Please sign in to comment.