Skip to content

Commit

Permalink
[IPV6]: ICMP6_MIB_OUTMSGS increment duplicated
Browse files Browse the repository at this point in the history
icmpv6_send() calls ip6_push_pending_frames() indirectly.
Both ip6_push_pending_frames() and icmpv6_send() increment
counter ICMP6_MIB_OUTMSGS.

This patch remove the increment from icmpv6_send.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wang Chen authored and David S. Miller committed Jan 21, 2008
1 parent 6836545 commit c964ff4
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/ipv6/icmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,6 @@ void icmpv6_send(struct sk_buff *skb, int type, int code, __u32 info,
}
err = icmpv6_push_pending_frames(sk, &fl, &tmp_hdr, len + sizeof(struct icmp6hdr));

ICMP6_INC_STATS_BH(idev, ICMP6_MIB_OUTMSGS);

out_put:
if (likely(idev != NULL))
in6_dev_put(idev);
Expand Down

0 comments on commit c964ff4

Please sign in to comment.