Skip to content

Commit

Permalink
x86, xen: do multicall callbacks with interrupts disabled
Browse files Browse the repository at this point in the history
We can't call the callbacks after enabling interrupts, as we may get a
nested multicall call, which would cause a great deal of havok.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Jeremy Fitzhardinge authored and Ingo Molnar committed Feb 16, 2009
1 parent 3d39e9d commit c996086
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/x86/xen/multicalls.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,15 @@ void xen_mc_flush(void)
} else
BUG_ON(b->argidx != 0);

local_irq_restore(flags);

for (i = 0; i < b->cbidx; i++) {
struct callback *cb = &b->callbacks[i];

(*cb->fn)(cb->data);
}
b->cbidx = 0;

local_irq_restore(flags);

WARN_ON(ret);
}

Expand Down

0 comments on commit c996086

Please sign in to comment.