Skip to content

Commit

Permalink
PCI PM: Fix poweroff and restore callbacks
Browse files Browse the repository at this point in the history
pci_fixup_device() is called too early in pci_pm_poweroff() and too
late in pci_pm_restore().  Moreover, pci_pm_restore_noirq() calls
pci_fixup_device() twice and in a wrong way.  Fix that.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Rafael J. Wysocki authored and Jesse Barnes committed Jan 7, 2009
1 parent 987a4c7 commit c9b9972
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/pci/pci-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,6 @@ static int pci_pm_poweroff(struct device *dev)
struct device_driver *drv = dev->driver;
int error = 0;

pci_fixup_device(pci_fixup_suspend, pci_dev);

if (drv && drv->pm) {
if (drv->pm->poweroff) {
error = drv->pm->poweroff(dev);
Expand All @@ -622,6 +620,8 @@ static int pci_pm_poweroff(struct device *dev)
error = pci_legacy_suspend(dev, PMSG_HIBERNATE);
}

pci_fixup_device(pci_fixup_suspend, pci_dev);

return error;
}

Expand All @@ -648,6 +648,8 @@ static int pci_pm_restore(struct device *dev)
struct device_driver *drv = dev->driver;
int error = 0;

pci_fixup_device(pci_fixup_resume, pci_dev);

if (drv && drv->pm) {
if (drv->pm->restore)
error = drv->pm->restore(dev);
Expand All @@ -656,7 +658,6 @@ static int pci_pm_restore(struct device *dev)
} else {
error = pci_default_pm_resume_late(pci_dev);
}
pci_fixup_device(pci_fixup_resume, pci_dev);

return error;
}
Expand All @@ -667,7 +668,7 @@ static int pci_pm_restore_noirq(struct device *dev)
struct device_driver *drv = dev->driver;
int error = 0;

pci_fixup_device(pci_fixup_resume, pci_dev);
pci_fixup_device(pci_fixup_resume_early, pci_dev);

if (drv && drv->pm) {
if (drv->pm->restore_noirq)
Expand All @@ -677,7 +678,6 @@ static int pci_pm_restore_noirq(struct device *dev)
} else {
pci_default_pm_resume_early(pci_dev);
}
pci_fixup_device(pci_fixup_resume_early, pci_dev);

return error;
}
Expand Down

0 comments on commit c9b9972

Please sign in to comment.