Skip to content

Commit

Permalink
spi: signedness bug in qspi_trigger_transfer_out_int()
Browse files Browse the repository at this point in the history
We need "ret" to be unsigned for the error handling to work.  The
signedness of "i" and "n" don't matter but qspi_set_send_trigger()
returns an int so I've changed them to int as well.

Fixes: 4b6fe3e ('spi: Using Trigger number to transmit/receive data')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Dan Carpenter authored and Mark Brown committed Apr 6, 2015
1 parent 4b6fe3e commit c9bc3e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-rspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ static int rspi_rz_transfer_one(struct spi_master *master,
static int qspi_trigger_transfer_out_int(struct rspi_data *rspi, const u8 *tx,
u8 *rx, unsigned int len)
{
unsigned int i, n, ret;
int i, n, ret;
int error;

while (len > 0) {
Expand Down

0 comments on commit c9bc3e8

Please sign in to comment.