Skip to content

Commit

Permalink
thermal: cpu_cooling: Don't check is_cpufreq_valid()
Browse files Browse the repository at this point in the history
Because get_cpu_frequency() has returned a valid frequency, it means that the
cpufreq policy is surely valid and so no point checking that again with
is_cpufreq_valid(). Get rid of the routine as well as there are no more users.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
  • Loading branch information
Viresh Kumar authored and Eduardo Valentin committed Dec 8, 2014
1 parent e1fae55 commit c9ca319
Showing 1 changed file with 1 addition and 19 deletions.
20 changes: 1 addition & 19 deletions drivers/thermal/cpu_cooling.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,23 +110,6 @@ static void release_idr(struct idr *idr, int id)

/* Below code defines functions to be used for cpufreq as cooling device */

/**
* is_cpufreq_valid - function to check frequency transitioning capability.
* @cpu: cpu for which check is needed.
*
* This function will check the current state of the system if
* it is capable of changing the frequency for a given @cpu.
*
* Return: 0 if the system is not currently capable of changing
* the frequency of given cpu. !0 in case the frequency is changeable.
*/
static int is_cpufreq_valid(int cpu)
{
struct cpufreq_policy policy;

return !cpufreq_get_policy(&policy, cpu);
}

enum cpufreq_cooling_property {
GET_LEVEL,
GET_FREQ,
Expand Down Expand Up @@ -300,8 +283,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
cpufreq_device->cpufreq_state = cooling_state;
cpufreq_device->cpufreq_val = clip_freq;

if (is_cpufreq_valid(cpu))
cpufreq_update_policy(cpu);
cpufreq_update_policy(cpu);

return 0;
}
Expand Down

0 comments on commit c9ca319

Please sign in to comment.