Skip to content

Commit

Permalink
ipheth: remove incorrect devtype to WWAN
Browse files Browse the repository at this point in the history
The 'wwan' devtype is meant for devices that require preconfiguration
and *every* time setup before the ethernet interface can be used, like
cellular modems which require a series of setup commands on serial ports
or other mechanisms before the ethernet interface will handle packets.

As ipheth only requires one-per-hotplug pairing setup with no
preconfiguration (like APN, phone #, etc) and the network interface is
usable at any time after that initial setup, remove the incorrect
devtype wwan.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Williams authored and David S. Miller committed Sep 10, 2010
1 parent 201b6ba commit c9cedbb
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/net/usb/ipheth.c
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,6 @@ static const struct net_device_ops ipheth_netdev_ops = {
.ndo_get_stats = &ipheth_stats,
};

static struct device_type ipheth_type = {
.name = "wwan",
};

static int ipheth_probe(struct usb_interface *intf,
const struct usb_device_id *id)
{
Expand All @@ -450,7 +446,7 @@ static int ipheth_probe(struct usb_interface *intf,

netdev->netdev_ops = &ipheth_netdev_ops;
netdev->watchdog_timeo = IPHETH_TX_TIMEOUT;
strcpy(netdev->name, "wwan%d");
strcpy(netdev->name, "eth%d");

dev = netdev_priv(netdev);
dev->udev = udev;
Expand Down Expand Up @@ -500,7 +496,6 @@ static int ipheth_probe(struct usb_interface *intf,

SET_NETDEV_DEV(netdev, &intf->dev);
SET_ETHTOOL_OPS(netdev, &ops);
SET_NETDEV_DEVTYPE(netdev, &ipheth_type);

retval = register_netdev(netdev);
if (retval) {
Expand Down

0 comments on commit c9cedbb

Please sign in to comment.