Skip to content

Commit

Permalink
parisc: Fix A500 boot crash
Browse files Browse the repository at this point in the history
I believe the following change will fix the cache/TLB inconsistency
observed by Meelis.  After changing the page table entries, we need to
flush the cache and TLB to ensure that we don't have any stale PTE
values in the cache or TLB.

The alternative patching is done after all CPUs are running.  Thus, we
need to flush the whole cache and TLB.

I included the init section in the range modified by map_pages as
suggested by Helge.  Some routines in the init section may require
patching.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
John David Anglin authored and Helge Deller committed Oct 28, 2018
1 parent 87613bb commit c9fa406
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions arch/parisc/mm/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -513,17 +513,15 @@ static void __init map_pages(unsigned long start_vaddr,

void __init set_kernel_text_rw(int enable_read_write)
{
unsigned long start = (unsigned long)_stext;
unsigned long start = (unsigned long)__init_begin;
unsigned long end = (unsigned long)_etext;

map_pages(start, __pa(start), end-start,
PAGE_KERNEL_RWX, enable_read_write ? 1:0);

/* force the kernel to see the new TLB entries */
__flush_tlb_range(0, start, end);

/* dump old cached instructions */
flush_icache_range(start, end);
/* force the kernel to see the new page table entries */
flush_cache_all();
flush_tlb_all();
}

void __ref free_initmem(void)
Expand Down

0 comments on commit c9fa406

Please sign in to comment.