Skip to content

Commit

Permalink
drm/lsdc: Request PCI BAR
Browse files Browse the repository at this point in the history
lsdc currently just ioremaps its PCI BAR with pcim_iomap(). Performing
a region regquest additionally can make the driver more robust.

Replace pcim_iomap() with the managed function pcim_iomap_region() which
performs the request and ioremaps the BAR.

Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Link: https://patchwork.freedesktop.org/patch/msgid/20241021091116.14368-1-pstanner@redhat.com
  • Loading branch information
Philipp Stanner authored and Sui Jingfeng committed Nov 25, 2024
1 parent 850d71f commit ca053ee
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/gpu/drm/loongson/lsdc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,9 @@ lsdc_create_device(struct pci_dev *pdev,
lsdc_gem_init(ddev);

/* Bar 0 of the DC device contains the MMIO register's base address */
ldev->reg_base = pcim_iomap(pdev, 0, 0);
if (!ldev->reg_base)
return ERR_PTR(-ENODEV);
ldev->reg_base = pcim_iomap_region(pdev, 0, "lsdc");
if (IS_ERR(ldev->reg_base))
return ldev->reg_base;

spin_lock_init(&ldev->reglock);

Expand Down

0 comments on commit ca053ee

Please sign in to comment.