Skip to content

Commit

Permalink
PCI: Apply _HPP settings to all hot-added PCI devices
Browse files Browse the repository at this point in the history
We currently apply _HPP settings only to:

    - non-bridge devices, and
    - PCI-to-PCI bridges

i.e., we do not apply them to PCI-to-ISA bridges and the like.  It has been
that way since _HPP support was added by 40abb96 ("pciehp: Fix
programming hotplug parameters"), but I don't think there's any reason to
exclude these other bridges.

Apply _HPP settings to hot-added PCI devices of any type.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
  • Loading branch information
Bjorn Helgaas committed Sep 13, 2014
1 parent eab3a0e commit ca0647e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/pci/probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -1351,11 +1351,6 @@ static void pci_configure_device(struct pci_dev *dev)
if (system_state == SYSTEM_BOOTING)
return;

if (!(dev->hdr_type == PCI_HEADER_TYPE_NORMAL ||
(dev->hdr_type == PCI_HEADER_TYPE_BRIDGE &&
(dev->class >> 8) == PCI_CLASS_BRIDGE_PCI)))
return;

memset(&hpp, 0, sizeof(hpp));
ret = pci_get_hp_params(dev, &hpp);
if (ret)
Expand Down

0 comments on commit ca0647e

Please sign in to comment.