Skip to content

Commit

Permalink
x86/PCI: amd: Kill misleading message about enablement of IO access t…
Browse files Browse the repository at this point in the history
…o PCI ECS]

Commit 24d9b70 (x86: Use PCI method
for enabling AMD extended config space before MSR method) added a
message when IO access to PCI ECS was enabled via access to the NB_CFG
PCI register.  This can lead to a bogus message like

[    0.365177] Extended Config Space enabled on 0 nodes

which is misleading because IO ECS access is subsequently enabled for
AMD CPUs (that support this) by modifying the corresponding NB_CFG
MSR.

Furthermore it's not "Extended Config Space" that is enabled by this
register setting. It's the IO access that is enabled for extended
configruation space.

IMHO the ambiguous message needs to be cancelled.

Cc: Jan Beulich <jbeulich@novell.com>
Cc: Robert Richter <robert.richter@amd.com>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Andreas Herrmann authored and Jesse Barnes committed Jan 6, 2012
1 parent f676678 commit ca3671a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/x86/pci/amd_bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ static void __init pci_enable_pci_io_ecs(void)
++n;
}
}
pr_info("Extended Config Space enabled on %u nodes\n", n);
#endif
}

Expand Down

0 comments on commit ca3671a

Please sign in to comment.