Skip to content

Commit

Permalink
net: ethernet: nb8800: fix error return code in nb8800_open()
Browse files Browse the repository at this point in the history
Fix to return error code -ENODEV from the of_phy_connect() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Oct 17, 2016
1 parent ea93900 commit ca8eddc
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/ethernet/aurora/nb8800.c
Original file line number Diff line number Diff line change
Expand Up @@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
phydev = of_phy_connect(dev, priv->phy_node,
nb8800_link_reconfigure, 0,
priv->phy_mode);
if (!phydev)
if (!phydev) {
err = -ENODEV;
goto err_free_irq;
}

nb8800_pause_adv(dev);

Expand Down

0 comments on commit ca8eddc

Please sign in to comment.