Skip to content

Commit

Permalink
smbfs: read buffer overflow
Browse files Browse the repository at this point in the history
This function uses signed integers for the unix_date and local variables -
if a negative number is supplied and the leap-year condition is not met,
month will be 0, leading to a read of day_n[-1]

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Roel Kluin authored and Linus Torvalds committed Sep 23, 2009
1 parent fa081b0 commit ca976c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/smbfs/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ date_unix2dos(struct smb_sb_info *server,
month = 2;
} else {
nl_day = (year & 3) || day <= 59 ? day : day - 1;
for (month = 0; month < 12; month++)
for (month = 1; month < 12; month++)
if (day_n[month] > nl_day)
break;
}
Expand Down

0 comments on commit ca976c5

Please sign in to comment.