Skip to content

Commit

Permalink
net: dsa: mv88e6xxx: pass compatible info
Browse files Browse the repository at this point in the history
After allocating the chip structure, pass it a compatible info pointer.

The compatible info structure will be used later to describe how to
access the switch registers and where to read the switch ID.

For the standard MDIO probe, get it from the device node data. For the
legacy DSA driver probing, pass it the 88E6085 info.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vivien Didelot authored and David S. Miller committed Jun 21, 2016
1 parent bc46a3d commit caac854
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion drivers/net/dsa/mv88e6xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <linux/list.h>
#include <linux/mdio.h>
#include <linux/module.h>
#include <linux/of_device.h>
#include <linux/of_mdio.h>
#include <linux/netdevice.h>
#include <linux/gpio/consumer.h>
Expand Down Expand Up @@ -3617,6 +3618,7 @@ static int mv88e6xxx_detect(struct mv88e6xxx_priv_state *ps)
if (!info)
return -ENODEV;

/* Update the compatible info with the probed one */
ps->info = info;

dev_info(ps->dev, "switch 0x%x detected: %s, revision %u\n",
Expand Down Expand Up @@ -3669,6 +3671,9 @@ static const char *mv88e6xxx_drv_probe(struct device *dsa_dev,
if (!ps)
return NULL;

/* Legacy SMI probing will only support chips similar to 88E6085 */
ps->info = &mv88e6xxx_table[MV88E6085];

err = mv88e6xxx_smi_init(ps, bus, sw_addr);
if (err)
goto free;
Expand Down Expand Up @@ -3754,14 +3759,21 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
{
struct device *dev = &mdiodev->dev;
struct device_node *np = dev->of_node;
const struct mv88e6xxx_info *compat_info;
struct mv88e6xxx_priv_state *ps;
u32 eeprom_len;
int err;

compat_info = of_device_get_match_data(dev);
if (!compat_info)
return -EINVAL;

ps = mv88e6xxx_alloc_chip(dev);
if (!ps)
return -ENOMEM;

ps->info = compat_info;

err = mv88e6xxx_smi_init(ps, mdiodev->bus, mdiodev->addr);
if (err)
return err;
Expand Down Expand Up @@ -3801,7 +3813,10 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
}

static const struct of_device_id mv88e6xxx_of_match[] = {
{ .compatible = "marvell,mv88e6085" },
{
.compatible = "marvell,mv88e6085",
.data = &mv88e6xxx_table[MV88E6085],
},
{ /* sentinel */ },
};

Expand Down

0 comments on commit caac854

Please sign in to comment.