Skip to content

Commit

Permalink
drm/i915: fix CB tuning check for ILK+
Browse files Browse the repository at this point in the history
CB tuning is needed to handle potential process variations that might
cause clock jitter for certain PLL settings.  However, we were setting
it incorrectly since we were using the wrong M value as a check (M1 when
we needed to use the whole M value).  Fix it up, making my HDMI
attached display a little prettier (used to have occasional dots crawl
across the display).

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Keith Packard <keithp@keithp.com>
  • Loading branch information
Jesse Barnes authored and Keith Packard committed Jul 28, 2011
1 parent d74362c commit cb0e093
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -4994,7 +4994,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
} else if (is_sdvo && is_tv)
factor = 20;

if (clock.m1 < factor * clock.n)
if (clock.m < factor * clock.n)
fp |= FP_CB_TUNE;

dpll = 0;
Expand Down

0 comments on commit cb0e093

Please sign in to comment.