Skip to content

Commit

Permalink
Input: kbtab - validate number of endpoints before using them
Browse files Browse the repository at this point in the history
Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Johan Hovold authored and Dmitry Torokhov committed Mar 16, 2017
1 parent ba340d7 commit cb1b494
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/input/tablet/kbtab.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i
struct input_dev *input_dev;
int error = -ENOMEM;

if (intf->cur_altsetting->desc.bNumEndpoints < 1)
return -ENODEV;

kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL);
input_dev = input_allocate_device();
if (!kbtab || !input_dev)
Expand Down

0 comments on commit cb1b494

Please sign in to comment.