Skip to content

Commit

Permalink
selinux: avc_has_perm_flags has no more users
Browse files Browse the repository at this point in the history
.. so get rid of it.  The only indirect users were all the
avc_has_perm() callers which just expanded to have a zero flags
argument.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Linus Torvalds committed Oct 4, 2013
1 parent 19e4983 commit cb4fbe5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 17 deletions.
9 changes: 3 additions & 6 deletions security/selinux/avc.c
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,6 @@ inline int avc_has_perm_noaudit(u32 ssid, u32 tsid,
* @tclass: target security class
* @requested: requested permissions, interpreted based on @tclass
* @auditdata: auxiliary audit data
* @flags: VFS walk flags
*
* Check the AVC to determine whether the @requested permissions are granted
* for the SID pair (@ssid, @tsid), interpreting the permissions
Expand All @@ -756,17 +755,15 @@ inline int avc_has_perm_noaudit(u32 ssid, u32 tsid,
* permissions are granted, -%EACCES if any permissions are denied, or
* another -errno upon other errors.
*/
int avc_has_perm_flags(u32 ssid, u32 tsid, u16 tclass,
u32 requested, struct common_audit_data *auditdata,
unsigned flags)
int avc_has_perm(u32 ssid, u32 tsid, u16 tclass,
u32 requested, struct common_audit_data *auditdata)
{
struct av_decision avd;
int rc, rc2;

rc = avc_has_perm_noaudit(ssid, tsid, tclass, requested, 0, &avd);

rc2 = avc_audit(ssid, tsid, tclass, requested, &avd, rc, auditdata,
flags);
rc2 = avc_audit(ssid, tsid, tclass, requested, &avd, rc, auditdata, 0);
if (rc2)
return rc2;
return rc;
Expand Down
14 changes: 3 additions & 11 deletions security/selinux/include/avc.h
Original file line number Diff line number Diff line change
Expand Up @@ -147,17 +147,9 @@ int avc_has_perm_noaudit(u32 ssid, u32 tsid,
unsigned flags,
struct av_decision *avd);

int avc_has_perm_flags(u32 ssid, u32 tsid,
u16 tclass, u32 requested,
struct common_audit_data *auditdata,
unsigned);

static inline int avc_has_perm(u32 ssid, u32 tsid,
u16 tclass, u32 requested,
struct common_audit_data *auditdata)
{
return avc_has_perm_flags(ssid, tsid, tclass, requested, auditdata, 0);
}
int avc_has_perm(u32 ssid, u32 tsid,
u16 tclass, u32 requested,
struct common_audit_data *auditdata);

u32 avc_policy_seqno(void);

Expand Down

0 comments on commit cb4fbe5

Please sign in to comment.