Input: HID - fix potential out-of-bound array access

Fixes Coverity #id 978 Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
mariux64 · Jul 15, 2006 · cb78623 · cb78623
1 parent a2b2ed2
commit cb78623
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/usb/input/hid-input.c b/drivers/usb/input/hid-input.c
@@ -607,7 +607,8 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 
 	}
 
-	if (usage->hat_min < usage->hat_max || usage->hat_dir) {
+	if (usage->type == EV_ABS &&
+	    (usage->hat_min < usage->hat_max || usage->hat_dir)) {
 		int i;
 		for (i = usage->code; i < usage->code + 2 && i <= max; i++) {
 			input_set_abs_params(input, i, -1, 1, 0, 0);