Skip to content

Commit

Permalink
tools/virtio: Use tools/include/list.h instead of stubs
Browse files Browse the repository at this point in the history
It should not make any significant difference but reduce stub code.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Link: https://lore.kernel.org/r/20200418102217.32327-9-eperezma@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
Eugenio Pérez authored and Michael S. Tsirkin committed Jun 22, 2020
1 parent 1d8bf5c commit cb91909
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
7 changes: 1 addition & 6 deletions tools/virtio/linux/kernel.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include <linux/compiler.h>
#include <linux/types.h>
#include <linux/list.h>
#include <linux/printk.h>
#include <linux/bug.h>
#include <errno.h>
Expand Down Expand Up @@ -135,10 +136,4 @@ static inline void free_page(unsigned long addr)
(void) (&_min1 == &_min2); \
_min1 < _min2 ? _min1 : _min2; })

/* TODO: empty stubs for now. Broken but enough for virtio_ring.c */
#define list_add_tail(a, b) do {} while (0)
#define list_del(a) do {} while (0)
#define list_for_each_entry(a, b, c) while (0)
/* end of stubs */

#endif /* KERNEL_H */
5 changes: 2 additions & 3 deletions tools/virtio/linux/virtio.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@ struct device {
struct virtio_device {
struct device dev;
u64 features;
struct list_head vqs;
};

struct virtqueue {
/* TODO: commented as list macros are empty stubs for now.
* Broken but enough for virtio_ring.c
* struct list_head list; */
struct list_head list;
void (*callback)(struct virtqueue *vq);
const char *name;
struct virtio_device *vdev;
Expand Down
1 change: 1 addition & 0 deletions tools/virtio/virtio_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
int r;
memset(dev, 0, sizeof *dev);
dev->vdev.features = features;
INIT_LIST_HEAD(&dev->vdev.vqs);
dev->buf_size = 1024;
dev->buf = malloc(dev->buf_size);
assert(dev->buf);
Expand Down
2 changes: 2 additions & 0 deletions tools/virtio/vringh_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ static int parallel_test(u64 features,
close(to_host[0]);

gvdev.vdev.features = features;
INIT_LIST_HEAD(&gvdev.vdev.vqs);
gvdev.to_host_fd = to_host[1];
gvdev.notifies = 0;

Expand Down Expand Up @@ -453,6 +454,7 @@ int main(int argc, char *argv[])

getrange = getrange_iov;
vdev.features = 0;
INIT_LIST_HEAD(&vdev.vqs);

while (argv[1]) {
if (strcmp(argv[1], "--indirect") == 0)
Expand Down

0 comments on commit cb91909

Please sign in to comment.