Skip to content

Commit

Permalink
cavium/liquidio: fix some error handling in lio_set_phys_id()
Browse files Browse the repository at this point in the history
There was a missing assignment so the "if (ret)" on the next line is
never true.

Fixes: f21fb3e ('Add support of Cavium Liquidio ethernet adapters')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Jun 25, 2015
1 parent 5102e23 commit cbdb977
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,9 @@ static int lio_set_phys_id(struct net_device *netdev,
if (ret)
return ret;

octnet_mdio45_access(lio, 1, LIO68XX_LED_BEACON_ADDR,
&lio->phy_beacon_val);
ret = octnet_mdio45_access(lio, 1,
LIO68XX_LED_BEACON_ADDR,
&lio->phy_beacon_val);
if (ret)
return ret;

Expand Down

0 comments on commit cbdb977

Please sign in to comment.