Skip to content

Commit

Permalink
rbd: remove the ->set_read_only method
Browse files Browse the repository at this point in the history
Now that the hardware read-only state can't be changed by the BLKROSET
ioctl, the code in this method is not required anymore.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Acked-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Jan 25, 2021
1 parent 947139b commit cbf72cc
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions drivers/block/rbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -692,29 +692,10 @@ static void rbd_release(struct gendisk *disk, fmode_t mode)
put_device(&rbd_dev->dev);
}

static int rbd_set_read_only(struct block_device *bdev, bool ro)
{
struct rbd_device *rbd_dev = bdev->bd_disk->private_data;

/*
* Both images mapped read-only and snapshots can't be marked
* read-write.
*/
if (!ro) {
if (rbd_is_ro(rbd_dev))
return -EROFS;

rbd_assert(!rbd_is_snap(rbd_dev));
}

return 0;
}

static const struct block_device_operations rbd_bd_ops = {
.owner = THIS_MODULE,
.open = rbd_open,
.release = rbd_release,
.set_read_only = rbd_set_read_only,
};

/*
Expand Down

0 comments on commit cbf72cc

Please sign in to comment.