Skip to content

Commit

Permalink
net/fsl: xgmac_mdio: fix return value check in xgmac_mdio_probe()
Browse files Browse the repository at this point in the history
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 1d14eb1 ("net/fsl: xgmac_mdio: Use managed device resources")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Jan 31, 2022
1 parent 47ed944 commit cc4598c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/freescale/xgmac_mdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
priv = bus->priv;
priv->mdio_base = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(priv->mdio_base))
return PTR_ERR(priv->mdio_base);
if (!priv->mdio_base)
return -ENOMEM;

/* For both ACPI and DT cases, endianness of MDIO controller
* needs to be specified using "little-endian" property.
Expand Down

0 comments on commit cc4598c

Please sign in to comment.